flygard/flygard-core
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

docs(agents): key the self-review rule to opening a PR (#27272)

Browse source
This commit is contained in:
sudlud 2026-08-23 10:24:54 +02:00 committed by GitHub
parent f7f8d84c84
commit ca8e6d78de
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.agents/docs/code-review.md
View file

@ -26,10 +26,10 @@ line, not as background reading.
call leaves a null result, not just what enables it.
- Check the change is still needed against current `master`: the surrounding code may have moved,
or another change may have landed the same fix.
- On an existing PR, walk every discussion item one by one: what was raised, whether it was
answered, and whether it still applies to the current head. Never skip one because it looks
resolved, old, or minor; this walk overrides any read-comments-lightly default of the reviewing
skill. `gh pr view` misses review bodies and inline threads; pull all three:
- On an existing PR, walk every discussion item one by one, bot reviews included: what was raised,
whether it was answered, and whether it still applies to the current head. Never skip one
because it looks resolved, old, or minor; this walk overrides any read-comments-lightly default
of the reviewing skill. `gh pr view` misses review bodies and inline threads; pull all three:
```
gh api repos/azerothcore/azerothcore-wotlk/issues/<N>/comments --paginate # conversation comments

2
AGENTS.md
View file

@ -19,7 +19,7 @@ Read the matching doc(s) BEFORE starting the task:
- Creating or modifying SQL → `.agents/docs/sql-guidelines.md`
- SmartAI work (`smart_scripts` data) → also `.agents/docs/cpp-scripts.md`
- Reviewing a changeset or PR → `.agents/docs/code-review.md`
- Self-reviewing a changeset before submission → also `.agents/docs/self-review-rules.md`
- Self-reviewing, or opening or updating a PR → also `.agents/docs/self-review-rules.md`
- Touching a subsystem that has a doc in `.agents/docs/systems/` → read that doc too
- Capturing a lesson or adding/updating agent docs → `.agents/docs/README.md`